Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: consuldemocracy/consuldemocracy Loading
base: 07954f818bc531799ee487fd23cc173b72c5aa19
Choose a base ref
...
head repository: consuldemocracy/consuldemocracy Loading
compare: 79b1040189912c3b09022ac835f80e2513360b24
Choose a head ref
  • 9 commits
  • 18 files changed
  • 2 contributors

Commits on Aug 16, 2021

  1. Change Foundation text direction in RTL languages

    This way, when the language is written form right-to-left, elements
    using Foundation mixins/classes will float to the opposite direction as
    they do in left-to-right languages. The same will apply to text
    alignment.
    
    To offer full support for RTL languages, we need to change every single
    reference to `float: left`, `float: right`, `text-align: left`,
    `text-align: right`, and possible adjust other properties like `left`,
    `margin-left`, `padding-left` or `border-left`. In the meantime, we at
    least partially support these languages.
    
    Replacing `float` with `flex` when possible would also improve RTL
    support.
    javierm committed Aug 16, 2021
    Configuration menu
    Copy the full SHA
    a868a5f View commit details
    Browse the repository at this point in the history
  2. Set HTML dir attribute in RTL languages

    This way properties flex layouts text direction will work properly.
    javierm committed Aug 16, 2021
    Configuration menu
    Copy the full SHA
    d827768 View commit details
    Browse the repository at this point in the history

Commits on Aug 17, 2021

  1. Fix tests after replacing message with notification

    Looks like our test suite wasn't executed in commit 4dbc027, and so we
    weren't notified of these failures.
    javierm committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    d5d9eb5 View commit details
    Browse the repository at this point in the history
  2. Explicitely use Debian Buster in Dockerfile

    Debian Bullseye was released two days ago, and is now the default
    distribution for the Docker image.
    
    Our image isn't compatible with Debian Bullseye right now, and we
    haven't done any testing with it, so for now we're staying with Buster.
    javierm committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    2c84f77 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #4663 from consul/revert-4538-notificationTranslation

    Fix tests after replacing message with notification
    javierm committed Aug 17, 2021
    Configuration menu
    Copy the full SHA
    05869bf View commit details
    Browse the repository at this point in the history

Commits on Aug 18, 2021

  1. Merge pull request #4664 from consul/fix_dockerfile

    Explicitely use Debian Buster in Dockerfile
    javierm committed Aug 18, 2021
    Configuration menu
    Copy the full SHA
    8fdbd36 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #4647 from consul/rtl

    Improve support for RTL languages
    javierm committed Aug 18, 2021
    Configuration menu
    Copy the full SHA
    d32e2f9 View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2021

  1. Upgrade Ruby to version 2.7.4

    Note this version includes Bundler 2, so we can finally upgrade.
    javierm committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    4557606 View commit details
    Browse the repository at this point in the history
  2. Supress warnings in Paperclip::UrlGenerator

    We were getting hundreds of "warning: URI.escape is obsolete" messages.
    So we're using `URI::DEFAULT_PARSER.escape` instead.
    
    IMHO it's OK to add this monkey-patch because we're replacing Paperclip
    with Active Storage, and when we finish with that we'll delete this
    file.
    javierm committed Aug 25, 2021
    Configuration menu
    Copy the full SHA
    79b1040 View commit details
    Browse the repository at this point in the history
Loading