-
Notifications
You must be signed in to change notification settings - Fork 1.1k
/
budget_investments_spec.rb
512 lines (401 loc) · 20.4 KB
/
budget_investments_spec.rb
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
332
333
334
335
336
337
338
339
340
341
342
343
344
345
346
347
348
349
350
351
352
353
354
355
356
357
358
359
360
361
362
363
364
365
366
367
368
369
370
371
372
373
374
375
376
377
378
379
380
381
382
383
384
385
386
387
388
389
390
391
392
393
394
395
396
397
398
399
400
401
402
403
404
405
406
407
408
409
410
411
412
413
414
415
416
417
418
419
420
421
422
423
424
425
426
427
428
429
430
431
432
433
434
435
436
437
438
439
440
441
442
443
444
445
446
447
448
449
450
451
452
453
454
455
456
457
458
459
460
461
462
463
464
465
466
467
468
469
470
471
472
473
474
475
476
477
478
479
480
481
482
483
484
485
486
487
488
489
490
491
492
493
494
495
496
497
498
499
500
501
502
503
504
505
506
507
508
509
510
511
512
require "rails_helper"
describe "Valuation budget investments" do
let(:budget) { create(:budget, :valuating) }
let(:valuator) do
create(:valuator, user: create(:user, username: "Rachel", email: "[email protected]"))
end
before do
login_as(valuator.user)
end
context "Load" do
before { budget.update(slug: "budget_slug") }
scenario "finds investment using budget slug" do
visit valuation_budget_budget_investments_path("budget_slug")
expect(page).to have_content budget.name
end
scenario "raises an error if budget slug is not found" do
expect do
visit valuation_budget_budget_investments_path("wrong_budget")
end.to raise_error ActiveRecord::RecordNotFound
end
scenario "raises an error if budget id is not found" do
expect do
visit valuation_budget_budget_investments_path(0)
end.to raise_error ActiveRecord::RecordNotFound
end
end
scenario "Disabled with a feature flag" do
Setting["process.budgets"] = nil
expect do
visit valuation_budget_budget_investments_path(create(:budget))
end.to raise_exception(FeatureFlags::FeatureDisabled)
end
scenario "Display link to valuation section" do
visit root_path
expect(page).to have_link "Valuation", href: valuation_root_path
end
describe "Index" do
scenario "Index shows budget investments assigned to current valuator" do
investment1 = create(:budget_investment, :visible_to_valuators, budget: budget, valuators: [valuator])
investment2 = create(:budget_investment, :visible_to_valuators, budget: budget)
visit valuation_budget_budget_investments_path(budget)
expect(page).to have_content(investment1.title)
expect(page).not_to have_content(investment2.title)
end
scenario "Index shows no budget investment to admins no valuators" do
investment1 = create(:budget_investment, :visible_to_valuators, budget: budget, valuators: [valuator])
investment2 = create(:budget_investment, :visible_to_valuators, budget: budget)
logout
login_as create(:administrator).user
visit valuation_budget_budget_investments_path(budget)
expect(page).not_to have_content(investment1.title)
expect(page).not_to have_content(investment2.title)
end
scenario "Index orders budget investments by votes" do
investment10 = create(:budget_investment, :visible_to_valuators, budget: budget,
valuators: [valuator],
cached_votes_up: 10)
investment100 = create(:budget_investment, :visible_to_valuators, budget: budget,
valuators: [valuator],
cached_votes_up: 100)
investment1 = create(:budget_investment, :visible_to_valuators, budget: budget,
valuators: [valuator],
cached_votes_up: 1)
visit valuation_budget_budget_investments_path(budget)
expect(investment100.title).to appear_before(investment10.title)
expect(investment10.title).to appear_before(investment1.title)
end
scenario "Index displays investments paginated" do
per_page = Kaminari.config.default_per_page
(per_page + 2).times do
create(:budget_investment, :visible_to_valuators, budget: budget, valuators: [valuator])
end
visit valuation_budget_budget_investments_path(budget)
expect(page).to have_css(".budget_investment", count: per_page)
within("ul.pagination") do
expect(page).to have_content("1")
expect(page).to have_content("2")
expect(page).not_to have_content("3")
click_link "Next", exact: false
end
expect(page).to have_css(".budget_investment", count: 2)
end
scenario "Index filtering by heading", :js do
group = create(:budget_group, budget: budget)
valuating_heading = create(:budget_heading, name: "Only Valuating", group: group)
valuating_finished_heading = create(:budget_heading, name: "Valuating&Finished", group: group)
finished_heading = create(:budget_heading, name: "Only Finished", group: group)
create(:budget_investment, :visible_to_valuators, title: "Valuating Investment ONE",
heading: valuating_heading,
budget: budget,
valuators: [valuator])
create(:budget_investment, :visible_to_valuators, title: "Valuating Investment TWO",
heading: valuating_finished_heading,
budget: budget,
valuators: [valuator])
create(:budget_investment, :visible_to_valuators, :finished, title: "Finished ONE",
heading: valuating_finished_heading,
budget: budget,
valuators: [valuator])
create(:budget_investment, :visible_to_valuators, :finished, title: "Finished TWO",
heading: finished_heading,
budget: budget,
valuators: [valuator])
visit valuation_budget_budget_investments_path(budget)
expect(page).to have_link("Valuating Investment ONE")
expect(page).to have_link("Valuating Investment TWO")
expect(page).not_to have_link("Finished ONE")
expect(page).not_to have_link("Finished TWO")
expect(page).to have_link("All headings (4)")
expect(page).to have_link("Only Valuating (1)")
expect(page).to have_link("Valuating&Finished (2)")
expect(page).to have_link("Only Finished (1)")
click_link "Only Valuating (1)", exact: false
expect(page).to have_link("Valuating Investment ONE")
expect(page).not_to have_link("Valuating Investment TWO")
expect(page).not_to have_link("Finished ONE")
expect(page).not_to have_link("Finished TWO")
click_link "Valuation finished"
expect(page).not_to have_link("Valuating Investment ONE")
expect(page).not_to have_link("Valuating Investment TWO")
expect(page).not_to have_link("Finished ONE")
expect(page).not_to have_link("Finished TWO")
click_link "Valuating&Finished (2)", exact: false
expect(page).not_to have_link("Valuating Investment ONE")
expect(page).to have_link("Valuating Investment TWO")
expect(page).not_to have_link("Finished ONE")
expect(page).not_to have_link("Finished TWO")
click_link "Valuation finished"
expect(page).not_to have_link("Valuating Investment ONE")
expect(page).not_to have_link("Valuating Investment TWO")
expect(page).to have_link("Finished ONE")
expect(page).not_to have_link("Finished TWO")
click_link "Only Finished (1)", exact: false
expect(page).not_to have_link("Valuating Investment ONE")
expect(page).not_to have_link("Valuating Investment TWO")
expect(page).not_to have_link("Finished ONE")
expect(page).not_to have_link("Finished TWO")
click_link "Valuation finished"
expect(page).not_to have_link("Valuating Investment ONE")
expect(page).not_to have_link("Valuating Investment TWO")
expect(page).not_to have_link("Finished ONE")
expect(page).to have_link("Finished TWO")
end
scenario "Current filter is properly highlighted" do
filters_links = { "valuating" => "Under valuation",
"valuation_finished" => "Valuation finished" }
visit valuation_budget_budget_investments_path(budget)
expect(page).not_to have_link(filters_links.values.first)
filters_links.keys.drop(1).each { |filter| expect(page).to have_link(filters_links[filter]) }
filters_links.each_pair do |current_filter, link|
visit valuation_budget_budget_investments_path(budget, filter: current_filter)
expect(page).not_to have_link(link)
(filters_links.keys - [current_filter]).each do |filter|
expect(page).to have_link(filters_links[filter])
end
end
end
scenario "Index filtering by valuation status" do
create(:budget_investment, :visible_to_valuators,
budget: budget, valuators: [valuator], title: "Ongoing valuation")
create(:budget_investment, :visible_to_valuators, :finished,
budget: budget, valuators: [valuator], title: "Old idea")
visit valuation_budget_budget_investments_path(budget)
expect(page).to have_content("Ongoing valuation")
expect(page).not_to have_content("Old idea")
visit valuation_budget_budget_investments_path(budget, filter: "valuating")
expect(page).to have_content("Ongoing valuation")
expect(page).not_to have_content("Old idea")
visit valuation_budget_budget_investments_path(budget, filter: "valuation_finished")
expect(page).not_to have_content("Ongoing valuation")
expect(page).to have_content("Old idea")
end
end
describe "Show" do
let(:administrator) do
create(:administrator, user: create(:user, username: "Ana", email: "[email protected]"))
end
let(:second_valuator) do
create(:valuator, user: create(:user, username: "Rick", email: "[email protected]"))
end
let(:investment) do
create(:budget_investment, :unfeasible, budget: budget, price: 1234,
unfeasibility_explanation: "It is impossible",
administrator: administrator,
valuators: [valuator, second_valuator])
end
scenario "visible for assigned valuators" do
investment.update!(visible_to_valuators: true)
visit valuation_budget_budget_investments_path(budget)
click_link investment.title
expect(page).to have_content("Investment preview")
expect(page).to have_content(investment.title)
expect(page).to have_content(investment.description)
expect(page).to have_content(investment.author.name)
expect(page).to have_content(investment.heading.name)
expect(page).to have_content("1234")
expect(page).to have_content("Unfeasible")
expect(page).to have_content("It is impossible")
expect(page).to have_content("Ana ([email protected])")
within("#assigned_valuators") do
expect(page).to have_content("Rachel ([email protected])")
expect(page).to have_content("Rick ([email protected])")
end
end
scenario "visible for admins" do
logout
login_as create(:administrator).user
visit valuation_budget_budget_investment_path(budget, investment)
expect(page).to have_content("Investment preview")
expect(page).to have_content(investment.title)
expect(page).to have_content(investment.description)
expect(page).to have_content(investment.author.name)
expect(page).to have_content(investment.heading.name)
expect(page).to have_content("1234")
expect(page).to have_content("Unfeasible")
expect(page).to have_content("It is impossible")
expect(page).to have_content("Ana ([email protected])")
within("#assigned_valuators") do
expect(page).to have_content("Rachel ([email protected])")
expect(page).to have_content("Rick ([email protected])")
end
end
scenario "not visible for not assigned valuators" do
logout
login_as create(:valuator).user
expect do
visit valuation_budget_budget_investment_path(budget, investment)
end.to raise_error "Not Found"
end
end
describe "Valuate" do
let(:admin) { create(:administrator) }
let(:investment) do
create(:budget_investment, budget: budget, price: nil, administrator: admin, valuators: [valuator])
end
scenario "Dossier empty by default" do
investment.update!(visible_to_valuators: true)
visit valuation_budget_budget_investments_path(budget)
click_link investment.title
within("#price") { expect(page).to have_content("Undefined") }
within("#price_first_year") { expect(page).to have_content("Undefined") }
within("#duration") { expect(page).to have_content("Undefined") }
within("#feasibility") { expect(page).to have_content("Undecided") }
expect(page).not_to have_content("Valuation finished")
end
scenario "Edit dossier" do
investment.update!(visible_to_valuators: true)
visit valuation_budget_budget_investments_path(budget)
within("#budget_investment_#{investment.id}") do
click_link "Edit dossier"
end
fill_in "budget_investment_price", with: "12345"
fill_in "budget_investment_price_first_year", with: "9876"
fill_in "budget_investment_price_explanation", with: "Very cheap idea"
choose "budget_investment_feasibility_feasible"
fill_in "budget_investment_duration", with: "19 months"
click_button "Save changes"
expect(page).to have_content "Dossier updated"
visit valuation_budget_budget_investments_path(budget)
click_link investment.title
within("#price") { expect(page).to have_content("12345") }
within("#price_first_year") { expect(page).to have_content("9876") }
expect(page).to have_content("Very cheap idea")
within("#duration") { expect(page).to have_content("19 months") }
within("#feasibility") { expect(page).to have_content("Feasible") }
expect(page).not_to have_content("Valuation finished")
end
scenario "Feasibility can be marked as pending" do
visit valuation_budget_budget_investment_path(budget, investment)
click_link "Edit dossier"
expect(find("#budget_investment_feasibility_undecided")).to be_checked
choose "budget_investment_feasibility_feasible"
click_button "Save changes"
visit edit_valuation_budget_budget_investment_path(budget, investment)
expect(find("#budget_investment_feasibility_undecided")).not_to be_checked
expect(find("#budget_investment_feasibility_feasible")).to be_checked
choose "budget_investment_feasibility_undecided"
click_button "Save changes"
visit edit_valuation_budget_budget_investment_path(budget, investment)
expect(find("#budget_investment_feasibility_undecided")).to be_checked
end
scenario "Feasibility selection makes proper fields visible", :js do
feasible_fields = ["Price (€)", "Cost during the first year (€)", "Price explanation",
"Time scope"]
unfeasible_fields = ["Feasibility explanation"]
any_feasibility_fields = ["Valuation finished"]
undecided_fields = feasible_fields + unfeasible_fields + any_feasibility_fields
visit edit_valuation_budget_budget_investment_path(budget, investment)
expect(find("#budget_investment_feasibility_undecided")).to be_checked
undecided_fields.each do |field|
expect(page).to have_content(field)
end
choose "budget_investment_feasibility_feasible"
unfeasible_fields.each do |field|
expect(page).not_to have_content(field)
end
(feasible_fields + any_feasibility_fields).each do |field|
expect(page).to have_content(field)
end
choose "budget_investment_feasibility_unfeasible"
feasible_fields.each do |field|
expect(page).not_to have_content(field)
end
(unfeasible_fields + any_feasibility_fields).each do |field|
expect(page).to have_content(field)
end
click_button "Save changes"
visit edit_valuation_budget_budget_investment_path(budget, investment)
expect(find("#budget_investment_feasibility_unfeasible")).to be_checked
feasible_fields.each do |field|
expect(page).not_to have_content(field)
end
(unfeasible_fields + any_feasibility_fields).each do |field|
expect(page).to have_content(field)
end
choose "budget_investment_feasibility_undecided"
undecided_fields.each do |field|
expect(page).to have_content(field)
end
end
scenario "Finish valuation" do
investment.update!(visible_to_valuators: true)
visit valuation_budget_budget_investment_path(budget, investment)
click_link "Edit dossier"
find_field("budget_investment[valuation_finished]").click
click_button "Save changes"
visit valuation_budget_budget_investments_path(budget)
expect(page).not_to have_content investment.title
click_link "Valuation finished"
expect(page).to have_content investment.title
click_link investment.title
expect(page).to have_content("Valuation finished")
end
context "Reopen valuation" do
before do
investment.update(
valuation_finished: true,
feasibility: "feasible",
unfeasibility_explanation: "Explanation is explanatory",
price: 999,
price_first_year: 666,
price_explanation: "Democracy is not cheap",
duration: "1 light year"
)
end
scenario "Admins can reopen & modify finished valuation" do
logout
login_as(admin.user)
visit edit_valuation_budget_budget_investment_path(budget, investment)
expect(page).to have_selector("input[id='budget_investment_feasibility_undecided']")
expect(page).to have_selector("textarea[id='budget_investment_unfeasibility_explanation']")
expect(page).to have_selector("input[name='budget_investment[valuation_finished]']")
expect(page).to have_button("Save changes")
end
scenario "Valuators that are not admins cannot reopen or modify a finished valuation" do
visit edit_valuation_budget_budget_investment_path(budget, investment)
expect(page).not_to have_selector("input[id='budget_investment_feasibility_undecided']")
expect(page).not_to have_selector("textarea[id='budget_investment_unfeasibility_explanation']")
expect(page).not_to have_selector("input[name='budget_investment[valuation_finished]']")
expect(page).to have_content("Valuation finished")
expect(page).to have_content("Feasibility: Feasible")
expect(page).to have_content("Feasibility explanation: Explanation is explanatory")
expect(page).to have_content("Price (€): 999")
expect(page).to have_content("Cost during the first year: 666")
expect(page).to have_content("Price explanation: Democracy is not cheap")
expect(page).to have_content("Time scope: 1 light year")
expect(page).not_to have_button("Save changes")
end
end
scenario "Validates price formats" do
investment.update!(visible_to_valuators: true)
visit valuation_budget_budget_investments_path(budget)
within("#budget_investment_#{investment.id}") do
click_link "Edit dossier"
end
fill_in "budget_investment_price", with: "12345,98"
fill_in "budget_investment_price_first_year", with: "9876.6"
click_button "Save changes"
expect(page).to have_content("2 errors")
expect(page).to have_content("Only integer numbers", count: 2)
end
scenario "not visible to valuators when budget is not valuating" do
budget.update!(phase: "publishing_prices")
investment = create(:budget_investment, budget: budget, valuators: [valuator])
login_as(valuator.user)
visit edit_valuation_budget_budget_investment_path(budget, investment)
expect(page).to have_content("Investments can only be valuated when Budget is in valuating phase")
end
scenario "visible to admins regardless of not being in valuating phase" do
budget.update!(phase: "publishing_prices")
user = create(:user)
admin = create(:administrator, user: user)
valuator = create(:valuator, user: user)
investment = create(:budget_investment, budget: budget, valuators: [valuator])
login_as(admin.user)
visit valuation_budget_budget_investment_path(budget, investment)
click_link "Edit dossier"
expect(page).to have_content investment.title
end
end
end