Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hooks for toggling #8

Closed
matthewturk opened this issue Feb 19, 2024 · 3 comments · Fixed by #11
Closed

Hooks for toggling #8

matthewturk opened this issue Feb 19, 2024 · 3 comments · Fixed by #11
Assignees
Labels
enhancement New feature or request

Comments

@matthewturk
Copy link
Contributor

Hi! I love this plugin. I was wondering if it might be possible to put hooks in for toggling. This might be something that could be made generic, but the one hook that I think I would really benefit from would be to auto-toggle to make sure I'm not in vim mode when I add a card to a Canvas.

It might be sufficient to be able to do this just when file-open is triggered and the new file is a canvas -- have it drop back from vim mode then. This could be stuck behind a toggle setting.

This may be out of scope for this plugin, but it also seems like the best place for it. Would you be open to a PR implementing it?

@conneroisu
Copy link
Owner

Honestly, I think i like it! I would prefer it as a setting that one would have opt-in into however I will take a crack at this tomorrow. Thinking about a name like "Automatic Canvas Insert [opt-in]". I also agree that it should easy to do with on open invoked function.

@conneroisu
Copy link
Owner

Actually, I would happily accept a pr for this feature as I have a small amount of time to work on this feature right now.

@matthewturk
Copy link
Contributor Author

Thank you! I will give it a go and see what I can come up with. I appreciate the nudge!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants