Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance: FindCompletedEligibleOffsetsAndRemove method try replacing with cache of incomplete offsets #41

Closed
astubbs opened this issue Nov 30, 2020 · 2 comments
Closed

Performance: FindCompletedEligibleOffsetsAndRemove method try replacing with cache of incomplete offsets #41

astubbs opened this issue Nov 30, 2020 · 2 comments
Labels
draft-available low

Comments

@astubbs
Copy link
Contributor

astubbs commented Nov 30, 2020

TODO: This entire loop could be possibly redundant, if we instead track low water mark, and incomplete offsets as work is submitted and returned, then we don't need to scan through all the partition collections looking for them.
@astubbs astubbs added the good first issue Good for newcomers label Nov 30, 2020
@astubbs astubbs mentioned this issue Dec 7, 2020
Closed
@astubbs astubbs changed the title performance: findCompletedEligibleOffsetsAndRemove method try replacing with cache of incomplete offsets Performance: FindCompletedEligibleOffsetsAndRemove method try replacing with cache of incomplete offsets Dec 11, 2020
@astubbs astubbs added low and removed good first issue Good for newcomers labels Dec 11, 2020
@astubbs
Copy link
Contributor Author

astubbs commented Dec 14, 2020

relates to: #53

@johnbyrnejb
Copy link
Contributor

Closing Issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
draft-available low
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@astubbs @johnbyrnejb