Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement prototype-based var sources #6275

Open
vito opened this issue Nov 16, 2020 · 0 comments
Open

Implement prototype-based var sources #6275

vito opened this issue Nov 16, 2020 · 0 comments
Projects

Comments

@vito
Copy link
Member

vito commented Nov 16, 2020

Now that reading vars is done in a separate step (#6274) and has its own presence in the UI, we can make read_var run a container to fetch the credentials instead, with the container 'owned' by the step's plan ID, and showing progress/errors/etc. in the step output.

This could maybe be done backwards-compatibly by creating a prototype-based creds.Secrets implementation. (Though looking at it now, it could also be implemented by thiccening (exec.RunState).Get.)

@vito vito created this issue from a note in Epic #5229 (Current iteration) Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Epic #5229
  
Current iteration
Development

No branches or pull requests

1 participant