-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File keychain backend should bail in credential process rather than hanging #637
Comments
FWIW, I think the behavior while this "worked" for me wasn't to bail, but to just proceed by using an empty password? I'm actually not totally sure; I might not have ever utilized the credential helper explicitly by passing a |
Reported by Gautam in our community Slack and related to #610.
granted credential-process
hangs waiting for input on unlocking the credential file. The solution proposed in #610 is to installpass
, but Gautam is using a shared machine and it isn't desirable to force everyone to usepass
.Rather than prompting for user input we should bail if the credential file password is unset.
This will likely involve setting
PromptFunc
in the keychain config struct to return an error when used with thecredential_process
integration.The text was updated successfully, but these errors were encountered: