Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Generated files not updated for version 3.21.1 #421

Closed
ehoogeveen-medweb opened this issue Jun 8, 2023 · 1 comment
Closed

Generated files not updated for version 3.21.1 #421

ehoogeveen-medweb opened this issue Jun 8, 2023 · 1 comment

Comments

@ehoogeveen-medweb
Copy link
Contributor

ehoogeveen-medweb commented Jun 8, 2023 •
edited
Loading

I noticed that after updating from version 3.21.0 to version 3.21.1, our diff was empty, not reflecting the change from #420.

It looks like only countries/CA.yaml was updated in this release.

If I clone the repo and npm run all locally I also see updates to the following files:

  • data/holidays.json
  • src/data.js
  • lib/data.cjs
  • All the files in dist/

Could you have a look? Maybe some steps in the release workflow are happening in the wrong order.
@commenthol
Copy link
Owner

Hi @ehoogeveen-medweb ,

v3.21.2 has been published. This version should contain the required files.
I am sorry that this has happened.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@commenthol @ehoogeveen-medweb