-
Notifications
You must be signed in to change notification settings - Fork 234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature request] Expand pick
and omit
functionality
#170
Comments
Edit: I wrote a script to accomplish the above that omits all languages except English and removes all US state holidays except TX's, but the bundle is still quite large at 70KiB zipped. I see the Bundling with webpack section and webpack.config.js, but it's still not clear to me how to make use of that to further reduce bundle size. Any additional information would be appreciated. |
Hi @ilyakamens, |
Great library! But would it be possible to remove the moment-timezone dependency? |
Hi @commenthol,
Thanks for this great tool. I'd like to submit a feature request to expand the
pick
andomit
functionality when making a custom build. Specifically:pick
only certain US states (e.g., onlypick
holiday information for US + TX, andomit
the other state-specific holidays).omit
the holiday names in other languages (or topick
certain languages).I use this library to automatically display custom support / CX hours during my company's holidays. Even with the custom build (
holidays2json --pick US --min
), it adds 350KiB (80KiB zipped) to our bundle, which is quite a bit (it's the second-largest bundle in our app).Thank you for your consideration.
- Ilya
The text was updated successfully, but these errors were encountered: