Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ford: brief unknown gear shifter position while driving #27709

Closed
adeebshihadeh opened this issue Mar 27, 2023 · 6 comments
Closed

Ford: brief unknown gear shifter position while driving #27709

adeebshihadeh opened this issue Mar 27, 2023 · 6 comments
Labels
bug car vehicle-specific ford

Comments

@adeebshihadeh
Copy link
Contributor

54827bf84c38b14f|2023-03-26--10-40-08--11

Briefly changed from "Drive" to "UnknownPosition", according to the DBC. May need to add some hysteresis.

image

@adeebshihadeh adeebshihadeh added bug car vehicle-specific ford labels Mar 27, 2023
@adeebshihadeh adeebshihadeh changed the title Ford: false positive Ford: brief unknown gear shifter position while driving Mar 27, 2023
@sshane
Copy link
Contributor

sshane commented May 2, 2023

The message actually timed out for more than 0.5 seconds during this event as well (CAN parser waits for 1 second), it looks like there was some actual communication or sensor issue. The counter is also pretty flaky. Checking out the fleet data for this.

image

@sshane
Copy link
Contributor

sshane commented May 4, 2023

Only saw this on our car, one other time in Feb, but not a lot of rlogs to go off of. The ECU timed out sending messages, so I'm not sure using hysteresis is the best way to handle this. canValid didn't fall only because the message timed out for 5x its normal rate, not 10x like we check for. It should be fine to merge Ford for now and check the fleet data once we have more users driving, but I'll also pull a few more rlogs from Azure to check in the mean time.

@incognitojam
Copy link
Contributor

incognitojam commented May 16, 2023

Had the same alert again, believe it is the same issue
54827bf84c38b14f|2023-05-16--00-43-38--9
image

@sshane
Copy link
Contributor

sshane commented Aug 8, 2023

@incognitojam I know we discussed switching to the more reliable message from the engine/transmission (it's one of those) instead of the flaky knob position message. Was there any issues with the engine/transmission message?

@incognitojam
Copy link
Contributor

From what I can remember the signal from the gear shifter was the one which didn't go to "neutral / no gear" when the transmission changed gear. If we change this I think the Lincoln also had some differences which we should check too.

@sshane
Copy link
Contributor

sshane commented Jul 3, 2024

Fixed by #32886

@sshane sshane closed this as completed Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug car vehicle-specific ford
Projects
None yet
Development

No branches or pull requests

3 participants