-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CANPacker: some exceptions are silent #902
Labels
Comments
@adeebshihadeh I think this is worth raising an exception for, rather than adding to the valid flag for wrong signals we want to add. What do you think? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
For example, since we don't propagate exceptions from this function, if you pass certain inputs to make_can_msg (like a list instead of dict), you'll get an exception that Python never knows about. But do we never want to throw an exception? Related: #500
opendbc/can/packer_pyx.pyx
Lines 29 to 39 in 3ef35ed
The text was updated successfully, but these errors were encountered: