Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement support for "DaVinci Wide Gamut" colourspace. #648

Closed
KelSolaar opened this issue Nov 12, 2020 · 3 comments
Closed

Implement support for "DaVinci Wide Gamut" colourspace. #648

KelSolaar opened this issue Nov 12, 2020 · 3 comments

Comments

@KelSolaar
Copy link
Member

KelSolaar commented Nov 12, 2020

Via @jedypod.

References

r: 0.8000, 0.3130
g: 0.1682, 0.9877
b: 0.0790, -0.1155
w: 0.3127, 0.3290

image

@KelSolaar KelSolaar added this to the v0.3.16 milestone Nov 12, 2020
@KelSolaar KelSolaar changed the title Implement support for "Davinci Wide Gamut" colourspace. Implement support for "DaVinci Wide Gamut" colourspace. Nov 12, 2020
@KelSolaar
Copy link
Member Author

Seems like BMD made an error when implementing the colourspace in Resolve and their whitepaper described another set: https://documents.blackmagicdesign.com/InformationNotes/DaVinci_Resolve_17_Wide_Gamut_Intermediate.pdf?_v=1607414410000

      x      y
red   0.8000 0.3130
green 0.1618 0.9877
blue  0.0790 -0.1155
white 0.3127 0.3290

@KelSolaar
Copy link
Member Author

Some more weirdness:

>>> colour.primaries_whitepoint(np.array([[0.70062239, 0.14877482, 0.10105872], [0.27411851, 0.87363190, -0.14775041], [-0.09896291, -0.13789533, 1.32591599]]))
(array([[ 0.8   ,  0.313 ],
       [ 0.1682,  0.9877],
       [ 0.079 , -0.1155]]), array([ 0.3127,  0.329 ]))

@KelSolaar
Copy link
Member Author

From private conversations between BMD and @fredsavoir, the primaries as given in Resolve are correct. Closing this one!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant