Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement support for "Optimal Colour Stimuli" computation. #364

Open
KelSolaar opened this issue Dec 5, 2017 · 2 comments
Open

Implement support for "Optimal Colour Stimuli" computation. #364

KelSolaar opened this issue Dec 5, 2017 · 2 comments

Comments

@KelSolaar
Copy link
Member

KelSolaar commented Dec 5, 2017

We are currently using pre-computed Optimal Colour Stimuli tables from MacAdam (1935) and they are not very precise, only account from Luminance domain [10, 95] with the negative side-effect of labelling a lot of Munsell Real colours outside the MacAdam limits:

import colour

xyY_r = []
for _HVC, xyY in colour.MUNSELL_COLOURS_REAL:
    xyY_r.append(xyY * np.array([1.0, 1.0, 1.0 / 100.0]))
xyY_r = np.array(xyY_r)

iml = colour.is_within_macadam_limits(xyY_r, 'C')
print(len(xyY_r))
print(len(iml[iml == False]))
# 2734
# 829

We should improve this behaviour by implementing an analytical computation for Optimal Colour Stimuli.

References

@KelSolaar KelSolaar added this to the v0.3.11 milestone Dec 5, 2017
@KelSolaar KelSolaar changed the title Implement support "Optimal Colour Stimuli" computation. Implement support for "Optimal Colour Stimuli" computation. Dec 5, 2017
@KelSolaar KelSolaar modified the milestones: v0.3.11, v0.3.12 Dec 13, 2017
@KelSolaar KelSolaar modified the milestones: v0.3.12, v0.3.13 Mar 23, 2019
@KelSolaar KelSolaar modified the milestones: v0.3.13, v0.3.14 Apr 19, 2019
@KelSolaar KelSolaar removed the Ready label Sep 30, 2019
@KelSolaar KelSolaar modified the milestones: v0.3.14, v0.3.15 Oct 26, 2019
@KelSolaar KelSolaar modified the milestones: v0.3.15, v0.3.16 Jan 25, 2020
@KelSolaar KelSolaar modified the milestones: v0.3.16, v0.4.0 Nov 23, 2020
@gutenzwerg
Copy link

I wrote a program to calculate MacAdam-Limits. I presume it is, what was wished in this issue
I did already a pull request for this Feature/macadam limits #768

Every single whavelenght shoud be accurate enough. If necessary, it is possible to modify the program to use different cmfs instead of only CIE-31 2° by default.
MacAdamLimits

@KelSolaar KelSolaar modified the milestones: v0.4.0, v0.4.1, v0.4.2 Feb 19, 2022
@gutenzwerg
Copy link

As far as I see. My function "macadam_limits" is not build in in the actual version. Am I right?
I need help in resolving the moand conflicts written at the pull request. It all relates to stuff of rights and features within comment-areas. I have no idea what to write in.
Can anyone help me to resolve the conflicts? Otherwise this feature can not be implemented.

@KelSolaar KelSolaar modified the milestones: v0.4.2, v0.4.3 Nov 27, 2022
@KelSolaar KelSolaar modified the milestones: v0.4.3, v0.4.4 Aug 25, 2023
@KelSolaar KelSolaar modified the milestones: v0.4.4, v0.4.5 Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants