Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add function to get variant-label from path where r/I/p1/f are 0 #141

Closed
paolap opened this issue Oct 29, 2020 · 2 comments
Closed

add function to get variant-label from path where r/I/p1/f are 0 #141

paolap opened this issue Oct 29, 2020 · 2 comments
Assignees

Comments

@paolap
Copy link
Member

paolap commented Oct 29, 2020

We found a model that have wrong r/I/p and f values in their attributes.
Would be good to double check that variant label built from these is the same as path.

We could run these checks for all records or simply doing it when values are 0 or potentially missing as in the example

:initialization_index = 0 ;
:physics_index = 0 ;
:realization_index = 0 ; " ;
:forcing_index = 2 ;
variant-label here is r1i1p1f2

I can do this relatively easily if the record hasn't been excluded already.
I.e. this will fix returning the wrong member_id if you haven't use member-id as one of the selecting fields. If you use it as one of the selecting files however the record simply won't be returned by the database and there's nothing for clef to work one.
The only solution for that would be running the query without member_id first, correct the records (if nay) and then filter after that

@paolap paolap self-assigned this Oct 29, 2020
@paolap
Copy link
Member Author

paolap commented Oct 29, 2020

In commit b64601b , branch label check, it is fixing both varian_label and member_id so they appear correct at least in csv files
variant-label could be different if sub-experiment present but since this is fixing errors in files the likelihood of this happening for sub-experiments is currently very low.

@paolap paolap mentioned this issue Oct 29, 2020
@paolap
Copy link
Member Author

paolap commented Oct 30, 2020

this is available in release 1.2.1

@paolap paolap closed this as completed Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant