Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collect all tools under one namespace in umd. #695

Open
dimensi opened this issue Apr 7, 2019 · 0 comments
Open

Collect all tools under one namespace in umd. #695

dimensi opened this issue Apr 7, 2019 · 0 comments

Comments

@dimensi
Copy link

dimensi commented Apr 7, 2019

In webpack configs you not have standard naming convension for library name.
https://github.com/editor-js/image/blob/master/webpack.config.js#L45 here you set ImageTool,
https://github.com/editor-js/list/blob/master/webpack.config.js#L39 but here you set Link.
Webpack allow create namespaces for library. I think you must collect all tools under EditorJS namespace.

// webpack.config.js
{
  output: {
    path: __dirname + '/dist',
    publicPath: '/',
    filename: 'bundle.js',
    library: ['EditorJS', 'List'],
    libraryTarget: 'umd'
  }
}

Because EditorJS it's class you not get conflict of namespace, all tools will be collect as static methods.

@dimensi dimensi changed the title Coolect all tools under one namespace in umd. Collect all tools under one namespace in umd. Apr 7, 2019
@neSpecc neSpecc removed the feature label Jan 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants