fix(scroll): acidental scroll to top on iOS devices #2695
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When you type something on iOS, page will be scrolled to top.
IMG_5245.MP4
Fixes #2689
Possible fixes #2261
Cause
Due to lack of the "strict" mode in the
tsconfig
there was a missed problem in the "scroll-locker.ts" class.The iOS-specific method
unlockHard()
(called from the Popover'hide()
which is being called every keydown) checks fornull
, butthis.scrollPosition
wasundefined
initiallySolution
this.scrollPosition
withnull
explicitly.hide()
method. Now it won't trigger any logic if popover is already hidden (to prevent possible layout caused by CSS classes adding)