Right now we have several problems with Enter keydown.

Unexpected new line on Enter press with selected block without caret

The problem can be reproduced when there is no caret set, but the block is selected.

Since there is no caret in a Block, the Ui.ts module's enterKeydown is involved. We call BlockManager.insert() and Caret.setToBlock(), but we're not calling the event.preventDefault() to disable default "Enter" behaviour. There was no problem until the 2.29 because there was a delay between block adding and caret setting. This delay was removed by #2570 — now block addition follows by immediate focusing so Enter handler ends with caret in a new block and default behaviour (a linebreak) is happening.

Solution

Addition of event.preventDefault() after block insertion resolves the issue.

Autofocus loosing after Block Tunes opening.

Block Tunes have autofocus on search field. But the caret disappears in a moment:

After the focusing of the search field, the ui.ts@selectionChanged() callback is called. It checks if isCrossBlockSelectionStarted() to remove all ranges.

The problem was in the isCrossBlockSelectionStarted() it was treating the single selected block as a CBS. The requestAnimationFrame in input focusing was redundant and just hides the problem.

Block removing while Enter press on Block Tunes

It is related to the previous problem: after caret loosing, the enterKeydown !Selection.isSelectionExists leads us to the BlockSelection.clearSelection(event); where block was deleting.

Fix #2637