Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(toolbar): improve aligning with headings #2748

Merged
merged 13 commits into from
Jul 1, 2024
Merged

Conversation

neSpecc
Copy link
Member

@neSpecc neSpecc commented Jun 28, 2024

Problem

Toolbar is not aligned with Headings

toolbar-aligning-before.mov

Cause

Right now the Y coord of the toolbar is simply a sum of block Y and plugin's padding-top. But a baseline of the text is also depends on the line-height and font-size.

Solution

  1. Now we calculate the real baseline of the first input.
  2. If block has no inputs or input is far from the top edge (like in Image tool), we use Block Y + padding top, as before.

Resolves #2536

toolbar-aligning-after.mov

@neSpecc neSpecc merged commit 1c88d52 into next Jul 1, 2024
6 checks passed
@neSpecc neSpecc deleted the toolbar-aligning branch July 1, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Header elements aren't aligned with the toolbar actions
3 participants