Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: scroll up offset for blocks above viewport #2298

Merged
merged 3 commits into from
Mar 13, 2023
Merged

fix: scroll up offset for blocks above viewport #2298

merged 3 commits into from
Mar 13, 2023

Conversation

kiorq
Copy link
Contributor

@kiorq kiorq commented Mar 10, 2023 •
edited
Loading

Fixes issue where Move Up tune would scroll to top of page when the previous block is above viewport.

resolves #2297

@kiorq kiorq mentioned this pull request Mar 10, 2023
Closed
@kiorq kiorq force-pushed the move-up-tune-above-viewport-bug branch from e6fa111 to cbd44bb Compare March 10, 2023 11:07
@kiorq kiorq requested review from neSpecc and removed request for gohabereg, TatianaFomina and ilyamore88 March 10, 2023 11:08
neSpecc
neSpecc approved these changes Mar 10, 2023
View reviewed changes
Copy link
Member

@neSpecc neSpecc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, add a change log

@kiorq
Copy link
Contributor Author

kiorq commented Mar 12, 2023 •
edited
Loading

Thanks a ton for the approvals. Question: How soon could we expect v2.27.0 to be released?

@neSpecc neSpecc merged commit 9ae96b9 into codex-team:next Mar 13, 2023
@kiorq kiorq deleted the move-up-tune-above-viewport-bug branch March 14, 2023 00:25
@ilyamore88
Copy link
Member

Hi, @kiorq. We're working on the next release. If you need this fix ASAP, it's available in version 2.27.0-rc.2.

@kiorq
Copy link
Contributor Author

kiorq commented Mar 15, 2023

Awesome, we will use the pre release until the 2.27.0 is ready. Thanks a ton.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@neSpecc neSpecc neSpecc approved these changes

@TatianaFomina TatianaFomina TatianaFomina approved these changes

@ilyamore88 ilyamore88 ilyamore88 approved these changes

Assignees
No one assigned
Labels
important
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move up tune scrolls to top when previous block is above and outside view port
4 participants
@kiorq @ilyamore88 @neSpecc @TatianaFomina