fix(types): compiler error from importing type BlockToolData #2264

arkamali · 2023-02-02T08:03:35Z

Resolves #2209

vite v4.0.4 building for production...
node_modules/@editorjs/editorjs/types/configs/conversion-config.ts:1:1 - error TS1371: This import is never used as a value and must use 'import type' because 'importsNotUsedAsValues' 

1 import {BlockToolData} from '../tools';
  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

node_modules/@editorjs/editorjs/types/configs/conversion-config.ts:1:9 - error TS1444: 'BlockToolData' is a type and must be imported using a type-only import when 'preserveValueImports' and 'isolatedModules' are both enabled.

1 import {BlockToolData} from '../tools';

vite v4.0.4 building for production... node_modules/@editorjs/editorjs/types/configs/conversion-config.ts:1:1 - error TS1371: This import is never used as a value and must use 'import type' because 'importsNotUsedAsValues' 1 import {BlockToolData} from '../tools'; ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ node_modules/@editorjs/editorjs/types/configs/conversion-config.ts:1:9 - error TS1444: 'BlockToolData' is a type and must be imported using a type-only import when 'preserveValueImports' and 'isolatedModules' are both enabled. 1 import {BlockToolData} from '../tools';

…pr/2264

neSpecc · 2023-02-20T22:18:21Z

Thanks @arkamali and @TatianaFomina

arkamali requested review from neSpecc, gohabereg, TatianaFomina and ilyamore88 as code owners February 2, 2023 08:03

neSpecc added 3 commits February 17, 2023 02:28

Merge branch 'next' into pr/2264

5a015b3

pull next branch

3b75b48

update submodules

eecdae8

neSpecc added the important label Feb 17, 2023

Merge branch 'next' into patch-1

b1d2dd0

neSpecc changed the title ~~import BlockToolData as Type~~ fix(types): compiler error from importing type BlockToolData Feb 20, 2023

neSpecc added 4 commits February 20, 2023 22:30

Merge branch 'next' into pr/2264

1dd68a5

Merge branch 'patch-1' of https://github.com/arkamali/editor.js into …

0586835

…pr/2264

changelog added

31c58c7

code style update

ef2939e

neSpecc approved these changes Feb 20, 2023

View reviewed changes

neSpecc added the ready to be shipped label Feb 20, 2023

neSpecc mentioned this pull request Feb 20, 2023

fix(types): fix typescript compiler errors under strict mode #2210

Closed

TatianaFomina approved these changes Feb 20, 2023

View reviewed changes

neSpecc merged commit 7bd5c53 into codex-team:next Feb 20, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(types): compiler error from importing type BlockToolData #2264

fix(types): compiler error from importing type BlockToolData #2264

arkamali commented Feb 2, 2023 •

edited by neSpecc

Loading

neSpecc commented Feb 20, 2023

fix(types): compiler error from importing type BlockToolData #2264

fix(types): compiler error from importing type BlockToolData #2264

Conversation

arkamali commented Feb 2, 2023 • edited by neSpecc Loading

neSpecc commented Feb 20, 2023

arkamali commented Feb 2, 2023 •

edited by neSpecc

Loading