fix(block): remember plugin's content element instead of dom search #2311
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neSpecc
requested review from
gohabereg,
TatianaFomina and
ilyamore88
as code owners
gohabereg
approved these changes
Mar 17, 2023
ilyamore88
approved these changes
Mar 18, 2023
ilyamore88
reviewed
Mar 18, 2023
|
hey @ilyamore88, I actually dont work on this project. Maybe you send to the wrong person |
Done |
christoph-kluge
added a commit
to christoph-kluge/editor.js
that referenced
this pull request
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes several possible bugs caused by browser extensions (Grammarly, Quillbot, etc) that add their own nodes next to the tool-rendered element
Previously, we were searching the plugin's element inside our
.ce-block__contentelement children filtering extension nodes by hard-coded selectors.Now I'm saving the reference to the tool's element when we render it. Then it could be guaranteed accessed later.
Resolves #2269
Resolves #2235
Resolves #1519