Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix unstable block cut process #1489

Closed
hata6502 opened this issue Dec 25, 2020 · 0 comments
Closed

Fix unstable block cut process #1489

hata6502 opened this issue Dec 25, 2020 · 0 comments

Comments

@hata6502
Copy link
Contributor

Currently, the block cut process (ctrl + x) has a weakness of maintainability.
If use await in async function BlockSelection.copySelectedBlocks, cut process doesn't copy block data.
Because BlockManager.removeSelectedBlocks() is proceeded before BlockSelection.copySelectedBlocks.
This is the unstable async function usage.

Reproduction code: src/components/modules/blockSelection.ts

  public async copySelectedBlocks(e: ClipboardEvent): Promise<void> {
    await 1;

Please check: #1485

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant