-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bug] TypeError: Cannot read property 'deactivate' of null #1400
Comments
Related Issue: #919 (comment) |
Please fix this bug with 2.19.0 -
Happening here Does not happen with 2.18.0 |
Duplicate of #1380 |
Is there any update on this issue? I'm seeing this as well. I ran into this issue when using the readOnly flag set to true. When I remove the flag, it works fine. |
Is there any updates here? it breaks core functionality, since it doesn't allow to properly destroy previously created editor instance. |
having the same problem here as well. |
Not sure if this is ideal but for the time being if (instance) {
document.querySelector(`#${holder} .codex-editor`).remove();
} |
Hello! |
Duplicate #1380 |
I see this error in v2.22.2, when testing a custom Tool in a headless environment (using Cypress). Using |
I am trying to use editor.js with react hooks and every time I am trying to destroy the editor I get the following error:
TypeError: Cannot read property 'deactivate' of null
From what I can see, when you call the
destroy
method on the editor instance thedestroy
methods ofBlockSettings
andToolbox
are being called twice.src/codex.ts
: the first call to destroy happens in heresrc/components/modules/toolbar/index.ts
: the second call to destroy happens hereBoth
destroy
methods ofBlockSettings
andToolbox
are settingthis.flipper = null
after a callingthis.flipper.deactivate()
and thus the error message:TypeError: Cannot read property 'deactivate' of null
Steps to reproduce:
Demo App: https://react-editor.vercel.app/
Demo source code: https://github.com/riezler-co/editorjs-demo
The modified editorjs code: https://github.com/riezler-co/editor.js
Expected behavior:
I can destroy the editor without throwing an exception
Screenshots:
https://drive.google.com/file/d/1DMvTvP2MKnCPiOSW92tMKlGqTw1TBRHU/view?usp=sharing
Device, Browser, OS:
Version 86.0.4240.111 (Official Build) (64-bit)
Editor.js version:
2.19.0
Plugins you use with their versions:
none
The text was updated successfully, but these errors were encountered: