Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix compatibility with docker-machine 0.5.0 #102

Merged
merged 1 commit into from
Nov 9, 2015
Merged

fix compatibility with docker-machine 0.5.0 #102

merged 1 commit into from
Nov 9, 2015

Conversation

miquella
Copy link
Contributor

@miquella miquella commented Nov 6, 2015

docker-machine changed the inspect output, removing the StorePath
root-level key and adding a Driver > StorePath (which doesn't include
the full path to the machine as before)

docker-machine also changed the exit status for docker-machine start
if the machine is already running (now exits with 1)

fixes #99 and #100

@miquella
fix compatibility with docker-machine 0.5.0
5fb8e59 
docker-machine changed the inspect output, removing the `StorePath`
root-level key and adding a `Driver > StorePath` (which doesn't include
the full path to the machine as before)

docker-machine also changed the exit status for `docker-machine start`
if the machine is already running (now exits with 1)
@miquella miquella mentioned this pull request Nov 7, 2015
Closed
@miquella
Copy link
Contributor Author

miquella commented Nov 7, 2015

This pull request specifically addresses:

  1. docker-machine start dinghy now exiting with a status of 1, causing Machine "dinghy" is already running errors.
  2. docker-machine inspect dinghy having a different format which caused the generated ssh_config to be invalid, resulting in the Permission denied and Error executing command: ["sudo umount /Users || true"] errors.

codekitchen added a commit that referenced this pull request Nov 9, 2015
@codekitchen
Merge pull request #102 from miquella/docker-machine_0.5.0
6d7e23b 
fix compatibility with docker-machine 0.5.0
@codekitchen codekitchen merged commit 6d7e23b into codekitchen:master Nov 9, 2015
@codekitchen
Copy link
Owner

thanks @miquella , i'll build a new release.

I think it makes more sense to look at HostOptions.AuthOptions.StorePath rather than Driver.StorePath, since AuthOptions has the full path to the directory where the SSL certs are stored, which is what we are looking for, and the information under Driver could vary between virtualbox and vmware. I'll make that tweak.

@chinthakagodawita chinthakagodawita mentioned this pull request Nov 9, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error executing command: ["sudo umount /Users || true"]
2 participants
@miquella @codekitchen