Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dinghy start overrides :proxy_disabled preferences #261

Closed
charlesfleche opened this issue Dec 8, 2017 · 1 comment
Closed

dinghy start overrides :proxy_disabled preferences #261

charlesfleche opened this issue Dec 8, 2017 · 1 comment

Comments

@charlesfleche
Copy link

We are running dinghy with xhyve and deactivate the proxy to bind an nginx server directly to the port 80. Our preferences.yml looks like that:

---
:preferences:
  :proxy_disabled: true
  :fsevents_disabled: false
  :create:
    provider: xhyve
    memory: 1024
    cpus: 1
  :unfs_disabled: false
  :dns_disabled: false

However after a dinghy up the proxy_disabled setting is reset to false. So the first dinghy up will have the proxy turned off, but the second dinghy up will keep the proxy running, breaking our dev environment.

@codekitchen
Copy link
Owner

Hm yeah the logic got changed and is definitely wrong now. I've changed it back and pushed a new v4.6.1 release, so an update should get you fixed up.

Note that if you leave DNS enabled the http_proxy container will still be run, since it runs the DNS service too, it just won't bind to ports 80/443. I should probably rename the container or run two separate containers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants