Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dinghy should not hide docker-machine errors #152

Closed
fgrehm opened this issue Mar 4, 2016 · 2 comments
Closed

Dinghy should not hide docker-machine errors #152

fgrehm opened this issue Mar 4, 2016 · 2 comments

Comments

@fgrehm
Copy link
Contributor

fgrehm commented Mar 4, 2016

For example, when creating a VM using the xhyve provider and the xhyve driver is not set up, this is what we get on the console:

image

According to @zwily, that error did not show up when running dinghy create. There are likely other types of errors that can be surfaced to users but this seems like a place to start hunting them down 🔫


Fork of #139 (comment)

@codekitchen
Copy link
Owner

Dinghy already prints out the stderr of the docker-machine create command if it fails, so I dug into this a bit more. Turns out it's a bug in the checking logic, so I filed machine-drivers/docker-machine-driver-xhyve#104

Closing this in favor of that fix. Thanks.

@fgrehm
Copy link
Contributor Author

fgrehm commented Mar 10, 2016

Awesome! Thanks for digging into it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants