Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subcategory is displayed even if there is no subcategory to pick (🅼3) #92

Open
Tracked by #76
schlos opened this issue Aug 12, 2021 · 0 comments
Open
Tracked by #76
Assignees
Labels
🕷️ bug Something isn't working html/css

Comments

@schlos
Copy link
Member

schlos commented Aug 12, 2021

Describe the bug

Subcategory is displayed even if there is no subcategory to pick.

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior

Hide subcategory label when there is no content for sub-category dropdown.

Screenshots

https://snippyly.com/img/?q=QhlY6FvHUlQthOCNLXcW (&EDIT=gJxIQDiYhGEbS9UyurrM)

Desktop (please complete the following information):

  • OS: [e.g. Windows]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context

Check and use template variables to handle what is shown. Refer to:
https://gist.github.com/schlos/d1d3bd175dcee17a94ee5dd04726a716#file-fms-base-report-new-fill_in_details-html-L737

@schlos schlos added the 🕷️ bug Something isn't working label Aug 12, 2021
@schlos schlos added this to To do in Popravi.to priorities via automation Aug 12, 2021
@schlos schlos changed the title popravito: Subcategory is displayed even if there is no subcategory to pick popravito: Subcategory is displayed even if there is no subcategory to pick (🅼3) Aug 12, 2021
@schlos schlos moved this from Backlog to Development to-do in Popravi.to priorities Aug 24, 2021
@schlos schlos added html/css help wanted Extra attention is needed labels Nov 11, 2021
@schlos schlos self-assigned this Nov 11, 2021
@schlos schlos changed the title popravito: Subcategory is displayed even if there is no subcategory to pick (🅼3) Subcategory is displayed even if there is no subcategory to pick (🅼3) Nov 26, 2021
@schlos schlos removed the help wanted Extra attention is needed label Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🕷️ bug Something isn't working html/css
Projects
Popravi.to priorities
  
Development in progress
Development

No branches or pull requests

1 participant