Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User-login [BUG] #84

Closed
acharliekelly opened this issue Jul 16, 2021 · 4 comments
Closed

User-login [BUG] #84

acharliekelly opened this issue Jul 16, 2021 · 4 comments
Labels
bug Something isn't working frontend
Projects
National Police Data Collaborative MVP

Comments

@acharliekelly
Copy link
Collaborator

Sorry, this seems too small an issue to bother writing up, but the PR is already merged, so...

In frontend/pages/login.tsx, line 1, the import refers to ../user-login/user-login. But PR #83 updated the file to ../user-login/index.tsx to conform to NextJS routing conventions, so now the login page doesn't compile. localhost:3000/login. Just need to change that one line.
@acharliekelly acharliekelly added bug Something isn't working frontend labels Jul 16, 2021
@dylanesque
Copy link
Collaborator

dylanesque commented Jul 16, 2021 •
edited
Loading

This ticket should ideally trim the redundant routes: login.tsx/user-login folder and the registration.tsx/viewer-registration folder are 4 different endpoints serving 2 distinct resources. I think keeping the folder versions of those files and making sure they're named what we want those particular routes to be called would be the way to go here.

@srsexton94 srsexton94 moved this from To do to Reviewer approved in National Police Data Collaborative MVP Jul 17, 2021
@srsexton94 srsexton94 moved this from Reviewer approved to Done in National Police Data Collaborative MVP Jul 17, 2021
@acharliekelly acharliekelly changed the title [BUG] User-login [BUG] Jul 20, 2021
@acharliekelly
Copy link
Collaborator Author

Oops, forgot to give this issue a title

@acharliekelly
Copy link
Collaborator Author

Maybe this issue should just fix the import typo, and trimming the enrollment routes should be included in #85?

@acharliekelly
Copy link
Collaborator Author

Never mind, this is incidentally fixed by #85 as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working frontend
Projects
National Police Data Collaborative MVP
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dylanesque @acharliekelly