Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Invalid form values don't prevent account creation #275

Closed
mikeyavorsky opened this issue May 10, 2023 · 3 comments
Closed

[BUG] Invalid form values don't prevent account creation #275

mikeyavorsky opened this issue May 10, 2023 · 3 comments
Labels
good first issue Good for newcomers

Comments

@mikeyavorsky
Copy link
Collaborator

Describe the bug
When using the signup form, validation errors don't prevent account creation.

To Reproduce
Steps to reproduce the behavior:

  1. Go to '/register'
  2. Fill in a last name with an _, or an invalid phone number
  3. An error should appear, and you will remain on the same screen
  4. Go to '/login'
  5. Try to login with the credentials used during the signup step

Expected behavior
If you encounter an error in the signup form, the account should not be created until the user fixes the issues.

Screenshots
Screen Shot 2023-05-09 at 9 23 58 PM
@mikeyavorsky mikeyavorsky added the good first issue Good for newcomers label May 10, 2023
@mikeyavorsky
Copy link
Collaborator Author

Brian S. is going to take a look.

@rosyntow
Copy link
Collaborator

Followed steps. Could not reproduce issue

@mikeyavorsky
Copy link
Collaborator Author

Can't reproduce on https://dev.nationalpolicedata.org/ either, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mikeyavorsky @rosyntow