Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Phone number field at Login should not require spaces #272

Closed
DMalone87 opened this issue Apr 5, 2023 · 1 comment
Closed

[BUG] Phone number field at Login should not require spaces #272

DMalone87 opened this issue Apr 5, 2023 · 1 comment

Comments

@DMalone87
Copy link
Collaborator

DMalone87 commented Apr 5, 2023

Describe the bug
When creating an account, the form will throw an error unless you use spaces in the phone number. Ex: "555 xxx xxxx". One should be able to use dashes or periods or the phone number should automatically add the desired formatting when you're typing out the number.

To Reproduce
Steps to reproduce the behavior:

  1. Go to 'dev.nationalpolicedata.org'
  2. Click on 'Join Us'
  3. Enter the required information into the form and click submit.
  4. See error

Expected behavior
When you are entering a phone number for the account creation process, it should either not be as strict or it should handle the formatting automatically.

Screenshots
Screen Shot 2023-04-04 at 9 22 16 PM

@rosyntow
Copy link
Collaborator

rosyntow commented Apr 28, 2023

I have created a pull request (#273) for this ticket.
Modified the regular expression to cover these variations of the formats of phone numbers below:
+123456789012
1234567890
(123) 456-7890
123-456-7890

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants