Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move cross origin BEFORE jwt_required #260

Merged
merged 1 commit into from
Sep 16, 2022
Merged

Move cross origin BEFORE jwt_required #260

merged 1 commit into from
Sep 16, 2022

Conversation

Logan-Dang
Copy link
Collaborator

@Logan-Dang Logan-Dang commented Sep 15, 2022

I love programming!

How to test:

  • In root dir, docker-compose up --build
  • In the browser, navigate to localhost:3000
  • Try registering
  • If sent to Dashboard, the login works!

Closes #257

@github-actions
Copy link

Visit the preview URL for this PR (updated for commit 838cf26):

https://police-data-trust-dev--pr260-jwt-fix-7101z2lz.web.app

(expires Thu, 22 Sep 2022 18:42:19 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 89ee28768ddf114979e2cf8eddd3746214cf93af

Copy link
Collaborator

@acharliekelly acharliekelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me - able to create new account and log in without CORS error on PR branch; not able to on current Dev site.

@acharliekelly acharliekelly merged commit cd811f1 into main Sep 16, 2022
@DMalone87 DMalone87 deleted the jwt-fix branch June 6, 2023 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Logging in doesn't work in dev environment.
2 participants