Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor and tests #253

Merged
merged 4 commits into from
Aug 17, 2022
Merged

Refactor and tests #253

merged 4 commits into from
Aug 17, 2022

Conversation

Logan-Dang
Copy link
Collaborator

Closes #252

How to test refactor:

  • npm run dev
  • Navigate to /officer/0
  • Confirm the officer page displays data
  • Navigate to different officers using different ids (ex. /officer/12, /officer/1) [0..99] for now

How to test tests:

  • npm test

@github-actions
Copy link

github-actions bot commented Jul 26, 2022

Visit the preview URL for this PR (updated for commit 627fa6a):

https://police-data-trust-dev--pr253-refactor-and-tests-pm06zvbm.web.app

(expires Wed, 24 Aug 2022 07:44:17 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 89ee28768ddf114979e2cf8eddd3746214cf93af

@Logan-Dang Logan-Dang marked this pull request as draft July 26, 2022 19:59
@JMStudiosJoe
Copy link
Collaborator

Looks like just update the snapshots and the tests should pass.

@Logan-Dang
Copy link
Collaborator Author

JS Dates and Timezones

@Logan-Dang Logan-Dang marked this pull request as ready for review August 10, 2022 19:37
JMStudiosJoe
JMStudiosJoe previously approved these changes Aug 16, 2022
Copy link
Collaborator

@JMStudiosJoe JMStudiosJoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a minor comment but looks great

@JMStudiosJoe JMStudiosJoe merged commit c676844 into main Aug 17, 2022
@DMalone87 DMalone87 deleted the refactor-and-tests branch June 6, 2023 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE]Create Officer and Incident Record View Tests
2 participants