Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] app.json #25

Closed
dwreeves opened this issue Apr 7, 2021 · 3 comments
Closed

[FEATURE] app.json #25

dwreeves opened this issue Apr 7, 2021 · 3 comments

Comments

@dwreeves
Copy link
Contributor

dwreeves commented Apr 7, 2021

Overview

The app.json is a Heroku deployment manifest file for apps that are not built via the container registry.

https://devcenter.heroku.com/articles/app-json-schema

Requirements for issue:

  • Create a valid app.json.
  • Add one of those "one click deploy" buttons in the README.md.

The previous project I worked on is a good example of how to do all these things: https://github.com/codeforboston/flagging

For our project we would just want the Postgres add-on, and a SECRET_KEY I think for now.

@dwreeves dwreeves changed the title [FEATURE] [FEATURE] app.json Apr 7, 2021
@dylanesque
Copy link
Collaborator

I got started on this, but it's not clear what you mean by "Add one of those "one-click deploy" buttons in the README.md"

@dwreeves
Copy link
Contributor Author

This thing:

image

It's simple to add to a README.md. This works for any arbitrary repo with a valid app.json.

[![Deploy](https://www.herokucdn.com/deploy/button.svg)](https://heroku.com/deploy)

@DMalone87
Copy link
Collaborator

Closing as this approach is not compatible with a Docker/Heroku pairing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants