Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Fix header to be mobile responsive and match designs #231

Closed
srsexton94 opened this issue Feb 9, 2022 · 2 comments
Closed

[BUG] Fix header to be mobile responsive and match designs #231

srsexton94 opened this issue Feb 9, 2022 · 2 comments
Labels
bug Something isn't working frontend good first issue Good for newcomers

Comments

@srsexton94
Copy link
Collaborator

The header/nav component is not fully mobile responsive, with the tabs falling off the screen at various breakpoints.

It also does not fully match the wireframes with element sizing and by missing the "DONATE" button (which should functionally be a link, the URL is still TBD we can use a placeholder for now)

Bug screenshots:
Screen Shot 2022-02-08 at 8 20 59 PM
Screen Shot 2022-02-08 at 8 21 25 PM

This ticket is to make sure that:

  1. Desktop and Mobile views match the wireframes
  2. All elements in the header, at all breakpoints between mobile and desktop, are visible, functional, and have generally reasonable proportions
  3. All elements in wireframes are included in the header (ie add the Donate button)

Final check - zoom page into 400% and make sure all elements are visible & functional (accessibility requirement - WCAG 1.4.10)
(Note: this should largely be handled by the mobile responsiveness - if this seems like it will significant complexity we can break it out into a separate ticket)

Wireframes for intended design:

Desktop Header
Mobile Header Closed
Mobile Header Open

Out of Scope:

This ticket is not concerned with...

  1. the mobile responsiveness with any content below the header
  2. the interaction design of the tabs/button (ie. you don't have to fix where these tabs are going if they're not correct/functional)
@srsexton94 srsexton94 added bug Something isn't working good first issue Good for newcomers frontend labels Feb 9, 2022
@azemetre
Copy link

Happy to take a crack at it.

@azemetre
Copy link

Will include adding the Donate link in the mobile view as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working frontend good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

4 participants