Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Enforce minimum role in @role_required #196

Closed
alexjball opened this issue Oct 20, 2021 · 0 comments · Fixed by #216
Closed

[FEATURE] Enforce minimum role in @role_required #196

alexjball opened this issue Oct 20, 2021 · 0 comments · Fixed by #216
Assignees
@arutfield
Labels
backend
Milestone
Authentication

Comments

@alexjball
Copy link
Member

The @role_required backend decorator checks that the authenticated user has a particular role. However, our roles are designed to provide increasing levels of access, so a passport user can access everything a public user can plus additional functionality.

So, we should change the @role_required decorator to check that the user has at least the specified role.
@alexjball alexjball added this to the Authentication milestone Oct 20, 2021
@alexjball alexjball mentioned this issue Oct 20, 2021
Merged
@arutfield arutfield self-assigned this Nov 10, 2021
@arutfield arutfield linked a pull request Nov 17, 2021 that will close this issue
Bugfix/role required at least #216
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@arutfield arutfield

Labels
backend
Projects
None yet
Milestone
Authentication
Development

Successfully merging a pull request may close this issue.

Bugfix/role required at least arutfield/police-data-trust
4 participants
@alexjball @arutfield @acharliekelly @edward-malouf