Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mock incident data #192

Merged
merged 8 commits into from
Oct 15, 2021
Merged

Mock incident data #192

merged 8 commits into from
Oct 15, 2021

Conversation

acharliekelly
Copy link
Collaborator

I've got several changes to data tables, but rather than making one big PR, I split stuff up. This PR is technically for #147, and does not impact the UI. I made some speculative interfaces for what the API data might look like, including:

  • Incident Table (the part that appears in the Search Results table, before you click on the Full Record)
  • Incident Detail (the Full Record)
  • Officer Record
  • Department

Also, some mock JSON data, including:

  • Incident Table data
  • Saved Results data (incident summary plus a search date field)
  • Incident Summary data merged with 2019 Grammy winners, because why not

I have modifications to the table components that display incident records, which I'm going to put in a separate PR.

alexjball
alexjball approved these changes Oct 15, 2021
View reviewed changes
Copy link
Member

@alexjball alexjball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!! I am implementing the incident search API in #191 and will follow these

@acharliekelly acharliekelly merged commit 37c08ee into codeforboston:main Oct 15, 2021
@acharliekelly acharliekelly linked an issue Oct 15, 2021 that may be closed by this pull request
[FEATURE] Create mock incident data #147
Closed
@acharliekelly acharliekelly mentioned this pull request Oct 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexjball alexjball alexjball approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Create mock incident data
2 participants
@acharliekelly @alexjball