Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] expose navigation state values #144

Closed
acharliekelly opened this issue Sep 3, 2021 · 0 comments
Closed

[FEATURE] expose navigation state values #144

acharliekelly opened this issue Sep 3, 2021 · 0 comments
Labels
frontend question Further information is requested

Comments

@acharliekelly
Copy link
Collaborator

The current Dashboard Header component gives control of the nav tabs to DesktopNav (and presumably also an as-yet released MobileNav), which stores them in internal state (which is fine, since so far the header has been purely decorative). But to make other parts of the app react to tab clicks, we either need to lift that value up to the Dashboard page, or use some other nifty tool to do the same thing.

Also, are we making Search, Profile, and About into fully-navigable pages, or just swapping the content of the dashboard?

@acharliekelly acharliekelly added question Further information is requested frontend labels Sep 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend question Further information is requested
Projects
None yet
Development

No branches or pull requests

1 participant