Run Flask dev server in docker-compose #119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@alexjball is this one ready to be reviewed or needs to pass all checks first? |
The node image uses npm 6, but npm 7 is available. Using npm 6 generates a warning about lockfile versions. Updating to 7 fixes the warning.
The compose file now runs the flask dev server and initializes tables on startup. Also exclude unnecessary folders from build contexts to reduce image size/build time.
This allows flask to reload when editing files.
|
@JMStudiosJoe This is ready to review. Checks should all be passing now |
JMStudiosJoe
approved these changes
Aug 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #118
Run the flask dev server and table init scripts on startup. Also exclude unnecessary folders from images to reduce size/build time.