Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added predictionfunction and models as folder #78

Merged
merged 4 commits into from
Sep 18, 2023

Conversation

dstalzjohn
Copy link
Collaborator

@dstalzjohn dstalzjohn commented Sep 18, 2023

📥 Pull Request Description

Allow models to be folders or files. Create a prediction function which handles different prediction model types.

👀 Affected Areas

  • documentation
  • configuration
  • implementation

📝 Checklist

Please make sure you've completed the following tasks before submitting this pull request:

  • Pre-commit hooks were executed
  • Changes have been reviewed by at least one other developer
  • Tests have been added or updated to cover the changes (only necessary if the changes affect the executable code)
  • All tests ran successfully
  • All merge conflicts are resolved
  • Documentation has been updated to reflect the changes
  • Any necessary migrations have been run

@dstalzjohn dstalzjohn added the ✨ feature Requests or discussions about new features label Sep 18, 2023
@dstalzjohn dstalzjohn self-assigned this Sep 18, 2023
Copy link
Collaborator

@aiakide aiakide left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see the review comments

…s/niceml into feature/models_as_folders

# Conflicts:
#	niceml/dlframeworks/tensorflow/predictionfunctions/keraspredictionfunction.py
#	niceml/mlcomponents/predictionfunction/predictionfunction.py
@aiakide aiakide enabled auto-merge (squash) September 18, 2023 14:43
@aiakide aiakide merged commit 368c25c into develop Sep 18, 2023
6 checks passed
@aiakide aiakide deleted the feature/models_as_folders branch September 19, 2023 12:56
@aiakide aiakide mentioned this pull request Sep 21, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ feature Requests or discussions about new features
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants