Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Return the experiment path instead of the experiment #76

Merged
merged 4 commits into from
Sep 14, 2023

Conversation

aiakide
Copy link
Collaborator

@aiakide aiakide commented Sep 14, 2023

📥 Pull Request Description

There was a bug that the get_exp_filepath function returns anExperimentInfo instead of the experiment file path if the exp_id is something else than "latest". This is fixed with this pull request.

👀 Affected Areas

  • eval pipeline --> load experiment

📝 Checklist

Please make sure you've completed the following tasks before submitting this pull request:

  • Pre-commit hooks were executed
  • Changes have been reviewed by at least one other developer
  • Tests have been added or updated to cover the changes (only necessary if the changes affect the executable code)
  • All tests ran successfully
  • All merge conflicts are resolved
  • Documentation has been updated to reflect the changes
  • Any necessary migrations have been run

📌 Related Issues

None

🔗 Links

None

📷 Screenshots

None

@aiakide aiakide added the 🪲 bug Related to bugs or unexpected behavior label Sep 14, 2023
@aiakide aiakide requested a review from ankeko September 14, 2023 12:17
@aiakide aiakide self-assigned this Sep 14, 2023
@aiakide aiakide merged commit 2d31041 into develop Sep 14, 2023
6 checks passed
@aiakide aiakide deleted the fix/exp-path-finder branch September 14, 2023 14:22
@aiakide aiakide mentioned this pull request Sep 21, 2023
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪲 bug Related to bugs or unexpected behavior
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants