Add dataframe filter to filter tabular data #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dstalzjohn
approved these changes
Jul 7, 2023
aiakide
added a commit
that referenced
this pull request
Jul 10, 2023
## 📥 Pull Request Description The following features and fixes will be part of the next release (`v0.6.0`) - feat: Add lockfile name as attribute of `FileChecksumProcessor ` (#46) - fix: Remove temp directory from hydra search path. Add hydra config mapping factory (#47) - fix: save result files from `tensorgraphanalyzer` at the correct place and implemented validation for that (#50) - feat: Add dagster op for dataframe normalization (#48) - feat: Add `NanDataframeFilter` to drop nan values of feature columns (#51) - fix: Adjust supported python versions in `Getting Started` docs section Additionally, there are several adjustments to the project organization - Pull request template added - Bug Report template added - Code of Conduct added ## 👀 Affected Areas - `FileChecksumProcessor ` - dagster ops - `df_normalization` - `DataframeFilter` - `NanDataframeFilter` - `tensorgraphanalyzer` - docs ## 📝 Checklist Please make sure you've completed the following tasks before submitting this pull request: - [X] Pre-commit hooks were executed - [ ] Changes have been reviewed by at least one other developer - [X] Tests have been added or updated to cover the changes (only necessary if the changes affect the executable code) - [X] All tests ran successfully - [X] All merge conflicts are resolved - [X] Documentation has been updated to reflect the changes - [X] Any necessary migrations have been run ## 📌 Related Issues _None_ ## 🔗 Links _None_ ## 📷 Screenshots _None_
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📥 Pull Request Description
A
DataframeFilteris used to filter tabular data in aDfDataset.Besides the abstract implementation, a
NaNDataframeFilterhas also been implemented, which removes rows with NaN values in the input and target columns of the data description.👀 Affected Areas
DataframeFilter(new)📝 Checklist
Please make sure you've completed the following tasks before submitting this pull request:
📌 Related Issues
None
🔗 Links
None
📷 Screenshots
None