Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove data block type in wal file #2083

Open
bartliu827 opened this issue Apr 22, 2024 · 1 comment
Open

remove data block type in wal file #2083

bartliu827 opened this issue Apr 22, 2024 · 1 comment

Comments

@bartliu827
Copy link
Contributor

Describe the issue
There is only on block type in wal data block,Do we need to keep it?

What you like us to do
image

Additional context
Add any other context about the issue here.

@zipper-meng
Copy link
Member

Removed type wal::Block and adjusted dependents.

/// Before
pub struct WalRecordData {
     pub typ: WalType,
     pub seq: u64,
     pub block: Block,
 }
/// After
pub struct WalRecordData {
     pub typ: WalType,
     pub seq: u64,
     pub block: Option<wal_store::RaftEntry>,
 }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants