[Brigade] Storage Tests #601
Replies: 5 comments 18 replies
-
|
Hey @nate-double-u. I'm unclear on status / next steps. Were all the project ideas for which you opened a discussion accepted? |
Beta Was this translation helpful? Give feedback.
-
|
Hi @krancour, no we're still in the discussion phase. Right now potential GSoC contributors should be discussing application ideas with the projects. That's what these discussions are intended to help with. The next key date in the process is April 4 (at 18:00 UTC), when the GSoC contributor application period begins. |
Beta Was this translation helpful? Give feedback.
-
|
So refer people to these discussions when they inquire? |
Beta Was this translation helpful? Give feedback.
-
|
These discussions, or your upstream issue. I probably should have linked them more closely, but either is fine. Also, I had meant to link it in my previous message, but here's the GSoC timeline: https://developers.google.com/open-source/gsoc/timeline |
Beta Was this translation helpful? Give feedback.
-
|
Awesome. Thanks for the info @nate-double-u! |
Beta Was this translation helpful? Give feedback.
-
|
Happy to help! 😃 |
Beta Was this translation helpful? Give feedback.
-
|
hello! i have been in touch with @krancour in slack over the last three weeks and have created a draft proposal that i would like to get feedback on to improve it before making the final submission. @nate-double-u is there an official process to request reviews from the mentors? |
Beta Was this translation helpful? Give feedback.
-
|
Hi, I had a confusion, do we need to replace all mock implementations by live database queries or need to deal with only the tests for the functions which execute database queries using the mongodb driver? |
Beta Was this translation helpful? Give feedback.
-
|
I think we're getting too far into implementation details here. |
Beta Was this translation helpful? Give feedback.
-
|
Oh I thought such details are required 😅. |
Beta Was this translation helpful? Give feedback.
-
|
Myself and another maintainer will have some say in what applications are accepted, but the people with final say, as I understand it, are CNCF org-level folks who do not necessarily have any in-depth familiarity with Brigade. Detail is good, but if we're down to the level of talking about file names, tags, specific functions, etc., those details won't mean anything to the people making the final call. |
Beta Was this translation helpful? Give feedback.
-
|
Oh, while writing my 2nd proposal which is for storage tests, I was trying to explain my strategy on almost all functions for which we need to write tests. Now after knowing this I'll try to avoid that as far as possible. |
Beta Was this translation helpful? Give feedback.
-
|
@krancour i have updated the timeline and uploaded the same to the gsoc website. i have sent a request on slack for a review, please let me know what your thoughts are. |
Beta Was this translation helpful? Give feedback.
-
|
Will it be a good idea to add the table of contents to the proposal pdfs? |
Beta Was this translation helpful? Give feedback.
-
|
I'm sorry I missed this before the submission deadline. Hopefully you submitted what you thought would be best. Generally on short or well structured documents I don't tend to include a table of contents, it depends on how complicated it is. |
Beta Was this translation helpful? Give feedback.
-
Yeah I thought that having that will help reviewers so I added that.
No issues. Actually, it's my fault that I didn't clear doubts beforehand. |
Beta Was this translation helpful? Give feedback.
-
Brigade's data access packages are currently unit-tested against mock implementations of MongoDB client interfaces. These tests have been adequate for asserting that queries and statements are constructed properly (look like we think they should) and that mock query and statement results can be unmarshaled without error into domain types, but this approach cannot assert that DB queries and statements are logically correct and actually achieve the desired results, since a live database would be required to accomplish that. Given the importance of the data access code, we would like to develop a new suite of integration tests directly targeted at that code. These new tests should run against a live (and disposable) MongoDB database and assert that all queries and statements achieve the desired results. If the new suite of tests exposes bugs in the existing data access code, correcting those bugs is within the scope of this project as well.
Mentor(s): Kent Rancourt (@krancour)
https://github.com/cncf/mentoring/blob/main/summerofcode/2022.md#storage-tests
Beta Was this translation helpful? Give feedback.
All reactions