Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Response.ResponseMessageDetail.messageErrorCode should be int, not java.lang.String #27

Open
malcos opened this issue Jun 14, 2024 · 0 comments · May be fixed by #28
Open

Response.ResponseMessageDetail.messageErrorCode should be int, not java.lang.String #27

malcos opened this issue Jun 14, 2024 · 0 comments · May be fixed by #28

Comments

@malcos
Copy link

malcos commented Jun 14, 2024

According to the documentation Responses & Errors - JSON provided by CM Telecom the field messageErrorCode should be an integer.

Bu the field in Response.java is a java.lang.String. This is not precisely a deal breaker but it produces an unnecessary implementation overhead converting this to a proper int on my end.

Please consider changing this and releasing a patch version of the library in Maven Central.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

change type of field messageErrorCode from java.lang.String to int malcos/cmdotcom-text-sdk-java
1 participant
@malcos