Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

@miniflare/shared should not depend on @types/better-sqlite3 #762

Closed
FlatMapIO opened this issue Mar 19, 2024 · 1 comment
Closed

@miniflare/shared should not depend on @types/better-sqlite3 #762

FlatMapIO opened this issue Mar 19, 2024 · 1 comment

Comments

@FlatMapIO
Copy link

FlatMapIO commented Mar 19, 2024

Although I've already included vitest-environment-miniflare/globals in types:

"types": [
  "@cloudflare/workers-types/2023-07-01",
  "vitest-environment-miniflare/globals"
]

But in vscode, the worker api still points to @types/node #761.

I looked up the following dependency via pnpm why @types/node.

vitest-environment-miniflare 2.14.2
├─┬ @miniflare/queues 2.14.2
│ └─┬ @miniflare/shared 2.14.2
│   └─┬ @types/better-sqlite3 7.6.9
│     └── @types/node 20.11.17

I think we should avoid introducing it to prevent type problems.

@penalosa
Copy link
Contributor

penalosa commented Jul 4, 2024

It looks like you're using the deprecated Miniflare v2. Miniflare 3's new Vitest integration should avoid this issue—could you give that a try?

@penalosa penalosa closed this as completed Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants