fix NotSupportedError when using NODE-ED25519 #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrbbot
reviewed
Aug 11, 2022
- Require `namedCurve` to be `NODE-ED25519` - Gate `Ed25519` usage behind feature detect - Use `Ed25519` algorithm object instead of string - Override `sign`, `verify` methods too - Do not require `importKey` to be within `RequestContext` - Automatically add `public: true` when importing `NODE-ED25519` keys - Upgrade `@types/node` for improved `webcrypto` types - Add tests for other algorithms using modified methods
|
Hey! 👋 I'm planning to get a release out today and would like to include this, so I've gone ahead and implemented the suggested fixes. 👍 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This closes #310 by adding a helper function that converts
NODE-ED25519toEd25519.I didn't add a check for just the string form (without the
namedCurve), since I wasn't sure if that's supported in the real CF worker env. But it would be super easy to add it to the helper.