Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot attach softevent #72

Closed
rexrock opened this issue Apr 1, 2020 · 3 comments
Closed

Cannot attach softevent #72

rexrock opened this issue Apr 1, 2020 · 3 comments

Comments

@rexrock
Copy link

rexrock commented Apr 1, 2020

There is a coding error in the PerfEvent struct:

diff --git a/config/config.go b/config/config.go
index 9c2a7a9..38ca87c 100644
--- a/config/config.go
+++ b/config/config.go
@@ -20,7 +20,7 @@ type Program struct {

 // PerfEvent describes perf_event to attach to
 type PerfEvent struct {
-       Type            int    `yaml:"string"`
+       Type            int    `yaml:"type"`
        Name            int    `yaml:"name"`
        Target          string `yaml:"target"`
        SamplePeriod    int    `yaml:"sample_period"`
@bobrik
Copy link
Contributor

bobrik commented Apr 1, 2020

Indeed! In the examples we only use HARDWARE type, which conveniently happens to be zero, so it works as expected there.

Do you want to make a PR yourself to correct this?

@rexrock
Copy link
Author

rexrock commented Apr 1, 2020

OK, I've done it.

@bobrik
Copy link
Contributor

bobrik commented Apr 1, 2020

Fixed in #73.

@bobrik bobrik closed this as completed Apr 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants