Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

why don't Port bcc libbpf-tools to ebpf_exporter example #246

Closed
cdkunsong opened this issue Aug 7, 2023 · 5 comments
Closed

why don't Port bcc libbpf-tools to ebpf_exporter example #246

cdkunsong opened this issue Aug 7, 2023 · 5 comments

Comments

@cdkunsong
Copy link

cdkunsong commented Aug 7, 2023

hi,
For ebpf_exporter, I would like to ask a question:
I see that ebpf_exporter supports bpf related,
for https://github.com/iovisor/bcc/tree/master/libbpf-tools,it have some good metrics example.
Why ebpf_exporter don't integrated libbpf-tools.
From the code point of view, it is possible, is there any other reason?

@bobrik
Copy link
Contributor

bobrik commented Aug 7, 2023

libbpf-tools are cli tools with varying plaintext output, ebpf_exporter is for properly formatted prometheus metrics.

Do you have a concrete idea on how these should be integrated?

@cdkunsong
Copy link
Author

yes, I checked biolatency.bpf.c, it references https://github.com/iovisor/bcc/blob/master/libbpf-tools/biolatency.bpf.c
What I want to know is why the inclusion of other related bpf programs is not considered?
Of course, it has some work to do.

commit e06bb8a
Author: Ivan Babrou [email protected]
Date: Sat Oct 15 18:48:29 2022 -0700

Port major examples to libbpf

diff --git a/examples/biolatency.yaml b/examples/biolatency.yaml
new file mode 100644
index 0000000..7b0f812
--- /dev/null
+++ b/examples/biolatency.yaml
@@ -0,0 +1,35 @@
+programs:

@bobrik
Copy link
Contributor

bobrik commented Aug 8, 2023

The included programs are examples, they are not the exhaustive set of what you can have. We add what we use and we certainly don't have the time to port every libbpf-tools program out there.

@cdkunsong
Copy link
Author

Thank you for your answer!

@cdkunsong
Copy link
Author

I have understood the situation,close issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants