Fix for problem with HLLE and near-dry states #163
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running a 1D dam-break simulation with a initial near-dry state, the HLLE solver gave a wrong solution. The following image corresponds to the output of hl=1, hr=1e-33, ul=ur=0, using the Classic solver with mx=4000 and order=1:
This seems to be caused by the denominator (s1-s2) getting close to zero while computing middle states. The proposed fix just sets the speeds and waves as zero whenever both hl and hr are smaller than a tolerance (1e-14). This is the output with the same initial values after applying the changes: