Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Warnings when using custom prop to force update #59

Open
bvisness opened this issue Jul 20, 2018 · 2 comments
Open

Warnings when using custom prop to force update #59

bvisness opened this issue Jul 20, 2018 · 2 comments

Comments

@bvisness
Copy link

I am using a custom prop to force my list to re-render, as recommended in the readme. However, doing so causes me this warning:

Warning: React does not recognize the isScrolling prop on a DOM element. If you intentionally want it to appear in the DOM as a custom attribute, spell it as lowercase isscrolling instead. If you accidentally passed it from a parent component, remove it from the DOM element.

(my prop is called isScrolling)

@bvisness
Copy link
Author

I was able to suppress the warning by naming my attribute data-is-scrolling. It might be nice to mention something about this in the docs.

@clauderic
Copy link
Owner

👍 Good point. I think having a forceUpdate prop would make sense, this way we could explicitly exclude it from the passthrough props that are passed to the wrapper. If this is something you have time to tackle, I'd be happy to accept a PR to that effect. Otherwise I'll try to get around to it at some point 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants