[Experimental branch] Allow the entity to have a new id #1448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 885caaa The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
clauderic
reviewed
Jul 11, 2024
| @@ -38,7 +38,7 @@ export class Entity< | |||
| this.effects = () => [ | |||
| () => { | |||
| // Re-run this effect whenever the `id` changes | |||
| const {id: _, manager} = this; | |||
| const {id, manager} = this; | |||
There was a problem hiding this comment.
What's the difference between this code and the previous code?
There was a problem hiding this comment.
weren't we discarding the value of id from this here? (by assigning to _)
There was a problem hiding this comment.
The difference is when the effect runs again, it will use whatever id is set in this, instead of the id that was received by the class constructor. That way if the id changes you're using the new id, not the initially set one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the
idof the entity is updated from a component I noted that the element wasn't draggable anymore, as it if were not being detected. The reason was that the newidwas not being compared in theideffect atEntity.What I did was to change the effect to read the
idfromthisrather than using theidreceived by theconstructor. This makes sense because the newidis set to the class in the hooks:With this change it should be straightforward to add a "Clone" example to the stories. I can do that too if you're interested.